Skip to content
This repository was archived by the owner on Dec 6, 2021. It is now read-only.

docs(LDAP): Migrated from ERPNext and updated for new features#168

Merged
gavindsouza merged 3 commits intofrappe:masterfrom
jon-nfc:ldap-frappe-frappe-issue-13738
Oct 22, 2021
Merged

docs(LDAP): Migrated from ERPNext and updated for new features#168
gavindsouza merged 3 commits intofrappe:masterfrom
jon-nfc:ldap-frappe-frappe-issue-13738

Conversation

@jon-nfc
Copy link
Copy Markdown
Contributor

@jon-nfc jon-nfc commented Jul 28, 2021

URL for LDAP Integration on frappe docs will be: http://{hostname}/docs/user/en/integration/ldap-integration

🔗 Related Items
Proposal: frappe/frappe#13738
PR: frappe/frappe#13777
📖 Documentation
ERPNext: PR frappe/erpnext_documentation#376
Frappe: PR #168

New features/refactor for LDAP that requires documentation to be updated.

Tasks

  • Copy LDAP Docs from ERPNext
  • Update/re-write covering new features from PR above
    • [ ] Images in documentation updated with new interface layout N/A

@jon-nfc jon-nfc marked this pull request as ready for review July 28, 2021 07:29
@jon-nfc
Copy link
Copy Markdown
Contributor Author

jon-nfc commented Jul 28, 2021

@frappe

Docs ready for review.

Question: I have placed in a troubleshooting section. what are your thoughts? is this required? or should I remove?

@jon-nfc
Copy link
Copy Markdown
Contributor Author

jon-nfc commented Jul 28, 2021

@hasnain2808,

I have just noticed that shortly after submitting my PR on frappe/erpnext_documentation#376 that repo was updated as archived.

I have seen the link to https://docs.erpnext.com/ however it doesn't work. Please advise on when this will be rectified. So that the changes to ERPNext docs can be submitted

@jon-nfc
Copy link
Copy Markdown
Contributor Author

jon-nfc commented Aug 20, 2021

@revant
Copy link
Copy Markdown
Collaborator

revant commented Aug 21, 2021

Let someone from core team comment.
I don't have updated info about how docs and docs contribution works.

@hasnain2808
Copy link
Copy Markdown
Contributor

hasnain2808 commented Aug 21, 2021

@jon-nfc
Apologies for the delay in response
Frappe docs still use this repository, so you need to open the pr in the traditional way
For Erpnext docs, we have started using https://www.github.com/frappe/wiki
Steps to contribute are available here
https://docs.erpnext.com/contribute
Please raise a change request according to these contribution guidelines

@gavindsouza gavindsouza merged commit e2190f8 into frappe:master Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants