Fix invalid SQL syntax in clause_discussions_commented_by_user for empty result sets

[Copilot]

clause_discussions_commented_by_user() materializes comment lookups into a Python list, then passes it to Discussion.name.isin(list). When a user has no comments, this generates WHERE name IN () — invalid SQL that triggers MariaDB error 1064.

Changes

• Replace materialized list with query builder subquery in clause_discussions_commented_by_user()
• Add test coverage for users with no comments

Before

commented_in = list(
    set(
        frappe.db.get_all(
            "GP Comment",
            fields=["reference_name"],
            filters={"reference_doctype": "GP Discussion", "owner": user},
            pluck="reference_name",
        )
    )
)
return Discussion.name.isin(commented_in)  # IN () when empty

After

Comment = frappe.qb.DocType("GP Comment")
commented_in = (
    frappe.qb.from_(Comment)
    .select(Comment.reference_name)
    .where((Comment.reference_doctype == "GP Discussion") & (Comment.owner == user))
)
return Discussion.name.isin(commented_in)  # IN (SELECT ...) — always valid

This matches the pattern already used in clause_discussions_bookmarked_by_user().

Original prompt

---

This section details on the original issue you should resolve

<issue_title>GP DIscussions API clause_discussions_commented_by_user returns Invalid SQL Syntax on no Comments by User</issue_title>
<issue_description>Error: When building the “Participating” feed (or when a participator filter is used), clause_discussions_commented_by_user() materializes a Python list of discussion names and returns Discussion.name.isin(list). For users with no comments, this produced an empty IN clause (IN ()), which renders invalid SQL and causes MariaDB error 1064.

Suggested Solution (Worked fine for me):

def clause_discussions_commented_by_user(user):
	Discussion = frappe.qb.DocType("GP Discussion")
	commented_in = list(
-	set(
-		frappe.db.get_all(
-			"GP Comment",
-			fields=["reference_name"],
-			filters={"reference_doctype": "GP Discussion", "owner": user},
-			pluck="reference_name",
-		)
+	Comment = frappe.qb.DocType("GP Comment")
+	commented_in = (
+		frappe.qb.from_(Comment)
+		.select(Comment.reference_name)
+		.where(
+			(Comment.reference_doctype == "GP Discussion")
+			& (Comment.owner == user)
		)
	)
	return Discussion.name.isin(commented_in)
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes GP DIscussions API clause_discussions_commented_by_user returns Invalid SQL Syntax on no Comments by User #430

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[cypress]

gameplan    Run #422

Run Properties:   Passed #422  •  aa6ff7f9aa ℹ️: Merge cf3648ab9a76ef799d1cc2e817132e126bfd4c4b into ed54ca3e6742086f72c85bd6ca89...

Project	gameplan
Branch Review	copilot/fix-invalid-sql-syntax
Run status	Passed #422
Run duration	00m 54s
Commit	aa6ff7f9aa ℹ️: Merge cf3648ab9a76ef799d1cc2e817132e126bfd4c4b into ed54ca3e6742086f72c85bd6ca89...
Committer	Copilot
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	7
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎