chore: Upgrade Vite stack and simplify config#471
Merged
netchampfaris merged 3 commits intodevelopfrom Mar 23, 2026
Merged
Conversation
- update frappe-ui
- Switch package manager from pnpm to yarn pnpm's strict dependency isolation prevents Vite 8 from discovering transitive CJS dependencies (highlight.js, interactjs) for pre-bundling, causing runtime ESM import errors. Yarn's flat hoisting makes these deps visible to the optimizer. - Upgrade Vite 4 to 8, @vitejs/plugin-vue 4 to 6, plugin-vue-jsx 3 to 5 - Upgrade @tiptap/* from v2 to v3 - Remove createResolveTiptapPlugin (unnecessary with tiptap v3) - Remove pnpm scripts, lockfiles, and install-pnpm.sh - Update CI workflow, devcontainer, and README for yarn - Update frappe-ui submodule
gameplan
|
||||||||||||||||||||||||||||||
| Project |
gameplan
|
| Branch Review |
vite-config-update
|
| Run status |
|
| Run duration | 00m 56s |
| Commit |
|
| Committer | Faris Ansari |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
7
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
netchampfaris
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Vite stack and simplify config
Vite config simplification
Replaced verbose per-option plugin config with
frontendRoute:frappe-ui now derives proxy, build output path, and
__FRONTEND_ROUTE__compile-time constant from the singlefrontendRouteoption. The router uses__FRONTEND_ROUTE__instead of the hardcoded/g/base path.Remove tiptap resolve plugin
createResolveTiptapPluginis no longer needed — frappe-ui and gameplan now use the same tiptap v3 version, so there are no conflicting resolutions to fix.Dependency upgrades
Switch from pnpm to yarn
pnpm's strict dependency isolation prevents Vite 8 from discovering transitive CJS dependencies (like
highlight.jsandinteractjs) for pre-bundling. Switched to yarn which hoists dependencies flat, matching frappe-ui's own package manager.Updated all references: root scripts, CI workflow, devcontainer setup, and README.