feat: use prose-v3 typography styles#473
Merged
netchampfaris merged 1 commit intodevelopfrom Apr 13, 2026
Merged
Conversation
… branch - Switch all editor instances from prose-sm to prose-v3 - Point frappe-ui to frappe/frappe-ui#better-prose-styles (frappe-ui PR: frappe/frappe-ui#620)
gameplan
|
||||||||||||||||||||||||||||||
| Project |
gameplan
|
| Branch Review |
better-prose-styles
|
| Run status |
|
| Run duration | 00m 55s |
| Commit |
|
| Committer | Faris Ansari |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
7
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch all TextEditor instances from
prose-smtoprose-v3.What is prose-v3?
prose-v3is a new Tailwind Typography modifier in frappe-ui that replacesprose-smas the default editor style. See frappe-ui PR: frappe/frappe-ui#620Key changes
data-themeFiles changed
editor-classprops updated fromprose-smtoprose-v3frappe-uipinned tofrappe/frappe-ui#better-prose-stylesData migration
Existing content authored with
prose-smhad automatic 8px paragraph margins. A one-time migration script will be needed to insert empty<p>tags between adjacent non-empty paragraphs in existing records. Details infrappe-ui/src/components/TextEditor/PROSE_V3.md.