Skip to content

Track comment content edits separately from reaction updates#476

Merged
netchampfaris merged 6 commits intodevelopfrom
copilot/fix-comment-edited-notification
Apr 22, 2026
Merged

Track comment content edits separately from reaction updates#476
netchampfaris merged 6 commits intodevelopfrom
copilot/fix-comment-edited-notification

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

Comments were deriving their edited state from the document modified timestamp, so reaction changes surfaced as Edited. This change introduces an explicit content-edit timestamp for GP Comment and drives the UI from that field instead of generic document mutation time.

  • Backend: explicit edit tracking

    • Added edited_at to GP Comment.
    • Set edited_at only when content changes on an existing comment.
    • Left reaction updates on normal document saves without treating them as content edits.
  • UI: edited state reflects content changes only

    • Switched the comment header Edited label to use comment.edited_at.
    • Switched Revisions visibility to the same field, so revision affordances only appear after a real content edit.
  • Data fetch/types

    • Included edited_at in comment list queries and GPComment typings so timeline consumers have the new source of truth.
  • Migration

    • Added a backfill patch that derives edited_at from Version rows where the content field changed.
    • Registered the patch under gameplan/gameplan/doctype/gp_comment/patches/ and updated patches.txt to the new module path.
<Tooltip
  v-if="comment.edited_at"
  :text="dayjsLocal(comment.edited_at).format('D MMM YYYY [at] h:mm A')"
>
  <span class="text-ink-gray-5">&nbsp;&middot; Edited</span>
</Tooltip>

Copilot AI and others added 6 commits April 21, 2026 20:14
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/2c04736d-02c3-4486-be2e-8cbbe3547894

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
Agent-Logs-Url: https://github.com/frappe/gameplan/sessions/cf2a5f48-b6e0-493b-b116-e29e7fd9152e

Co-authored-by: netchampfaris <9355208+netchampfaris@users.noreply.github.com>
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 22, 2026

gameplan    Run #420

Run Properties:  status check passed Passed #420  •  git commit 7c5e2da6ed ℹ️: Merge 4a66c24f5d4ecd026affed0c1d154a97368e12c1 into 6e460704a09a0681423e623b30c5...
Project gameplan
Branch Review copilot/fix-comment-edited-notification
Run status status check passed Passed #420
Run duration 00m 51s
Commit git commit 7c5e2da6ed ℹ️: Merge 4a66c24f5d4ecd026affed0c1d154a97368e12c1 into 6e460704a09a0681423e623b30c5...
Committer Copilot
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 7
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@netchampfaris netchampfaris merged commit ed54ca3 into develop Apr 22, 2026
3 checks passed
@netchampfaris netchampfaris deleted the copilot/fix-comment-edited-notification branch April 22, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants