Skip to content

Conversation

@simon-hirsch
Copy link
Contributor

Small MR for aligning return types, see #107

Copy link
Owner

@frazane frazane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simon-hirsch! The reason for not decorating some functions with the lazy wrapper is that they are pre-compiled instead of being compiled the first time they are called. This is done for the most popular metrics, and it was a tradeoff for speeding up import times. Could you revert that specific change?

Also side note: doing this

@lazy_gufunc_wrapper_mv
@guvectorize(
    [
        "void(float32[:], float32[:,:], float32[:])",
        "void(float64[:], float64[:,:], float64[:])",
    ],
    "(d),(m,d)->()",
    cache=True,
)

is redundant because if the types are specified in guvectorize the additional decorator is not necessary.

@simon-hirsch
Copy link
Contributor Author

Done :)

@frazane frazane self-requested a review January 21, 2026 09:55
@frazane frazane merged commit abfa21a into frazane:main Jan 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants