Fixing string.replace is not a function.

[rokyed]

No description provided.

[fredericd]

Thanks for your patch. Do you have sample data triggering the error/warning solved by your patch?

[rokyed]

Thanks for your patch. Do you have sample data triggering the error/warning solved by your patch?

@fredericd if the data appended to the Record is a Number, then this error will rise. I think it's a good idea to fix it at this level, although I will understand if you won't. From what I've read over MARC it should have no implication.

[fredericd]

@rokyed could you show me how and where you add a Number to a biblio Record? It will allow me to add a new entry to the module test suite.

[rokyed]

@fredericd

/*redacted*/

let rec = new Record();
rec.append(['001', 123456]);
let resp = rec.as('marcxml');

/*redacted*/

[fredericd]

It doesn't trigger an error/warning for me.

[rokyed]

@fredericd that was the only difference in my code that removed the error.