Open
Conversation
This reverts commit d987003.
Owner
|
Try to replace endless scrolling with the built in events: http://jscrollpane.kelvinluck.com/events.html Also make sure that we don't break the current support for window resizes. This is very exciting but I'm afraid we will break something whith a major change like this. Please contact me via email so we can continue the discussion there. |
remove endlessscroll
Author
|
okay, the last updates here should have restored the endless scroll functionality. resizing doesn't seem to be an issue. I'll email you soon. |
Owner
|
The code looks great, but may I suggest that you move the init code segment to the pear load function in pear.js. Also a demo page URL so I can test as well before auto merging. |
added 8 commits
August 19, 2012 22:59
also, fix content display issue for small thumbs / lots of available space
not sure of original purpose of the minus 2 there...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of jScrollPane (from http://jscrollpane.kelvinluck.com/ ) for pear4gallery3 in response to #34. It seems to work as it should for the most part, only the endless scrolling functionality is less smooth than previously (additional content is only loaded at the very end of scrolling, currently). This will also impact getScrollbarWidth, haven't looked at the specifics.