Merged
Conversation
ngie-eign
force-pushed
the
clean-up-ci-workflows
branch
11 times, most recently
from
f9d784e to
3866c22
Compare
ci-build.sh-related changes:
- Split up ci-build.sh into separate "steps" so the logic can be shared
between Cirrus CI and GHA. As of today there are just 2 steps:
- configure
- distcheck
- Set variables that can be overridden in the environment to sane
default values to support `set -eu` and to make the code
self-documenting.
- Apply `set -u` to catch undefined variables as part of the script
runtime.
- Remove i386 support: it's effectively a dead 32-bit platform now which
is not tested on a regular basis.
In the future the style checks will be split off of `make distcheck`,
i.e., once pre-commit integration is done.
GHA-specific changes:
- Make the file yamllint clean.
- Skip the job summarization step.
- The high-level summary provided by GHA each job is sufficient.
- Archive the test artifacts on completion so the GHA steps can be
debugged.
- Set the environment with `env` instead of via a separate
step with an undocumented interface, as `env` is the documented
interface for setting environment.
Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
ngie-eign
force-pushed
the
clean-up-ci-workflows
branch
from
3866c22 to
cf0b307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci-build.sh-related changes:
set -euand to make the code self-documenting.set -uto catch undefined variables as part of the script runtime.In the future the style checks will be split off of
make distcheck, i.e., once pre-commit integration is done.GHA-specific changes:
envinstead of via a separate step with an undocumented interface, asenvis the documented interface for setting environment.