Conversation
mchoo7
force-pushed
the
clang-format
branch
3 times, most recently
from
d0a2168 to
a66c981
Compare
ngie-eign
left a comment
ngie-eign
left a comment
There was a problem hiding this comment.
@fel1x-developer : for the sake of pragmatism, I think it's best to apply this change on a per-file basis since this is going to cause a lot of churn for little to no immediate benefit.
Also, there are a number of conflicts that need to be resolved in this change.
mchoo7
changed the title
|
Was this pulled from FreeBSD? If so, it might be better to figure out a way to keep this file in sync, somehow, instead of it drifting too far from upstream (freebsd-src). |
For now, automatically tracking updates in the freebse-src upstream is impossible. We can use post-commit hook as an alternative. By the way, the |
|
Could you please add a comment to the file to note where it came from (FreeBSD; git revision <...>)? Thanks :). |
mchoo7
force-pushed
the
clang-format
branch
2 times, most recently
from
9dfdf72 to
b1e4ae7
Compare
|
@ngie-eign Sorry this PR was mixed with other unrelated changes I was working on. We only need 1 commit where we bring We might need a git hook so people can format files according to |
ngie-eign
left a comment
ngie-eign
left a comment
There was a problem hiding this comment.
I looked at doing a similar change.
I think your proposal to introduce clang-format makes logical sense, but the implementation is a very high-impact/high churn change.
It's best to take the upstream FreeBSD config, and adjust it to match the existing style to reduce churn.
Once the core memory leak issues have been resolved and CI is enabled, I would be game to do widespread reformatting of the source in the repo.
This commit adopts FreeBSD's style(9). This file is retrieved from https://github.com/freebsd/freebsd-src/blob/main/.clang-format. Contributers can apply this style on modified files in future changes. Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me>
ngie-eign
force-pushed
the
clang-format
branch
from
b1e4ae7 to
a1ffeaa
Compare
2 participants
I find atk's coding style doesn't follow some conventions, such as having space in
<>or putting pointer*or reference symbol&with variable types, not variable names.FreeBSD's coding style style(9) can be applied here. One main exception in style(9) opposed to the "convention" is that style(9) use 8-space indentation while most projects use 4-space indentation. (2-space indentation is predominant in web dev). We can discuss whether or not to use 8-space indentation if needed.