Skip to content

Update bloomberg-industry-group-securedrop-ruleset.xml#266

Merged
nathandyer merged 5 commits intomainfrom
bbig-new-onion
Mar 11, 2026
Merged

Update bloomberg-industry-group-securedrop-ruleset.xml#266
nathandyer merged 5 commits intomainfrom
bbig-new-onion

Conversation

@ChumOfChance
Copy link
Contributor

@ChumOfChance ChumOfChance commented Mar 5, 2026

Bloomberg IG had a reinstall and now they have a new onion address.

Fixes #262

@ChumOfChance ChumOfChance requested a review from a team as a code owner March 5, 2026 16:23
@ChumOfChance ChumOfChance requested a review from nathandyer March 6, 2026 14:15
@nathandyer
Copy link
Collaborator

Thanks @ChumOfChance! In this case, I think it requires more than just changing the onion address in the ruleset.xml file. You can see an example of what a normal diff looks like for this: https://github.com/freedomofpress/securedrop-https-everywhere-ruleset/pull/163/changes

I believe there's a script that needs running, which bumps a few other files (onboarded.txt, latest-rulesets-timestamp, etc.). I also think that some of these need to be signed with our release key.

@legoktm is that approximately correct?

@legoktm legoktm self-assigned this Mar 6, 2026
@legoktm legoktm moved this to Ready For Review in SecureDrop Mar 6, 2026
@legoktm legoktm moved this from Ready For Review to In Progress in SecureDrop Mar 6, 2026
@legoktm legoktm moved this from In Progress to Ready For Review in SecureDrop Mar 11, 2026
@nathandyer
Copy link
Collaborator

nathandyer commented Mar 11, 2026

Review Checklist

  • Changes to onboarded.txt are accurate
  • The file default.rulesets.TIMESTAMP.gz has been updated, extracting that file and inspecting the contents of the JSON file produces the expected rules
  • The ruleset has been verified by modifying the HTTPS Everywhere configuration in a Tor Browser instance pointing to Path Prefix: https://raw.githubusercontent.com/freedomofpress/securedrop-https-everywhere-ruleset/$BRANCH_NAME
  • index.html has been updated using ./update_index.sh

Post-Deployment Checklist

  • Added/modified onion names have been updated in the SecureDrop Directory~

@ChumOfChance
Copy link
Contributor Author

Run through the review with @nathandyer and it's all good to go.

Copy link
Collaborator

@nathandyer nathandyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the review in #266 (comment)

@nathandyer nathandyer added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 97e853e Mar 11, 2026
3 checks passed
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in SecureDrop Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove politico.securedrop.tor.onion from the ruleset

3 participants