refactor: add comments and minor API improvements to api.rs#180
Open
redshiftzero wants to merge 1 commit intoreorganize-typesfrom
Open
refactor: add comments and minor API improvements to api.rs#180redshiftzero wants to merge 1 commit intoreorganize-typesfrom
api.rs#180redshiftzero wants to merge 1 commit intoreorganize-typesfrom
Conversation
redshiftzero
commented
Mar 8, 2026
| /// message IDs that were addressed to it, discarding the rest. | ||
| /// | ||
| /// Returns the set of [`Uuid`]s for messages belonging to this client. | ||
| fn solve_fetch_challenges(&self, challenges: &[FetchResponse]) -> Result<Vec<Uuid>, Error> |
Contributor
Author
There was a problem hiding this comment.
previously this took a Vec<FetchResponse> - do we want to consume the challenges here? if not, we can use the pattern from https://rust-lang.github.io/api-guidelines/flexibility.html#c-caller-control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incrementally adding comments to files, and making small API improvements, starting with
api.rsmainonce that is merged