Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 23, 2025

Implemented text-based parsing for amass v5 subdomain enumeration. Amass v5 outputs plain text (one subdomain per line) instead of JSON.

Changes

  • Output type: Changed from Tag to Subdomain
  • Parser: Implemented item_loader for line-by-line text parsing
  • Command: Removed -v flag, using amass enum -nocolor
  • Domain extraction: Added extract_domain_info to parse parent domain from subdomains
  • Removed: JSONSerializer and json_flag (amass v5 doesn't support JSON output)

Implementation

@staticmethod
def item_loader(self, line):
    """Parse amass text output line by line."""
    line = line.strip()
    if not line:
        return
    
    domain = extract_domain_info(line, domain_only=True)
    
    if domain:
        yield {
            'host': line,
            'domain': domain,
            'verified': False,
            'sources': ['amass']
        }

Follows the same pattern as other text-based parsers (fping, getasn, gf, mapcidr).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 23, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits November 23, 2025 13:36
Co-authored-by: ocervell <9629314+ocervell@users.noreply.github.com>
Co-authored-by: ocervell <9629314+ocervell@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 23, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • publicsuffix.org
    • Triggering command: /usr/bin/python3 python3 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add Amass-based subdomain enumeration task feat(tasks): implement amass v5 subdomain enumeration Nov 23, 2025
Copilot AI requested a review from ocervell November 23, 2025 13:42
@ocervell ocervell marked this pull request as ready for review November 23, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants