Fix race condition in state store cache updates #1753
Merged
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange (#1734) Co-authored-by: Claude <noreply@anthropic.com>
|
|
…ition When multiple concurrent operations access the state store, there was a race condition where GET requests could read stale cached data while the persistent store was being updated. This fix ensures the memory cache is updated first, preventing other threads from reading stale data during the update window. This change affects both update() and store() methods in StateStore. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
sanity
force-pushed
the
fix-state-store-cache-race-condition
branch
from
e4103db to
d410901
Compare
Co-authored-by: Ian Clarke <ian@freenet.org> Co-authored-by: Claude <noreply@anthropic.com>
sanity
force-pushed
the
fix-state-store-cache-race-condition
branch
from
e1db586 to
74cb02e
Compare
|
Rebased onto latest main after #1754 (timeout increases) merged. Re-running CI to pick up test stability improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
When multiple concurrent operations access the state store, there was a race condition where:
This fix ensures the memory cache is updated first, preventing other threads from reading stale data during the update window.
Test plan
While this fix didn't resolve the specific River chat test failure we were investigating, it does fix a legitimate race condition that could cause issues in high-concurrency scenarios. The change is a defensive improvement to prevent potential bugs.
🤖 Generated with Claude Code