fix: wrap NSView::new in unsafe block for objc2 compatibility#27
Merged
freethinkel merged 1 commit intofreethinkel:mainfrom Feb 6, 2026
Merged
Conversation
NSView::new was made unsafe in objc2-app-kit 0.3.x (following objc2's safety audit). This causes compilation errors with current Cargo.lock versions: error[E0133]: call to unsafe function `NSView::new` is unsafe and requires unsafe function or block The call is safe because we have a valid MainThreadMarker, which guarantees we're on the main thread as required by AppKit.
Owner
|
Thank you for the PR! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSView::newwas madeunsafeinobjc2-app-kit0.3.x as part of objc2's ongoing safety audit. This causes compilation errors when building with current dependency versions:Fix
Wrapped the
NSView::newcall in anunsafeblock with a safety comment. The call is safe because we have a validMainThreadMarker, which guarantees we're on the main thread as required by AppKit.Testing
cargo check- compiles successfully