-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add module for typesafe messages #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
freya022
wants to merge
32
commits into
3.X
Choose a base branch
from
feature/typesafe-messages
base: 3.X
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also set up module publications
So IJ doesn't think it can't be autowired
…ceFactory This allows running checks early Moved related tests, mock no-op MessageSourceGenerator when testing MessageSourceFactoryGenerator
This allows creating the factory with the minimum details, and to make actual instances using the returned callback Allows actual applications to run the checks before the beans get created Also simplifies tests that don't need actual instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the readme for details about this feature.
LocaleScopePREFER_USER: Use the user locale if availableGUILD: Use the guild locale@PreferLocaleScope, throw if both a preferred scope and a required locale parameter existsvalue:LocaleScopeDiscordLocale/Locale,null= use initial localecamelCaseparameters tosnake_caseObjects.requireNonNull(T, String)to simplify)FormattableArgumentConverter/ArgumentFormatter, maybe extend onParameterResolverDurationunless the user is able to localize thoseIMentionables where any mentionable entity is transformed into its mention@FormatWithto force usage of a specific formatter, for example the defaultIMentionableformatter could be overridden forMemberand instead insert the member's effective nameLocalizableTemplate#arguments: List<FormattableArgument>AddFormattableArgument#canFormat(Class<?>)Returntrueby default, document that in unknown cases, it should returntrueand just let it fail at runtimeMake sure to pass the final type (after conversion)