➖Remove async-trait in favor of native RPITIT#261
Open
a-kenji wants to merge 1 commit intofriedow:mainfrom
Open
➖Remove async-trait in favor of native RPITIT#261a-kenji wants to merge 1 commit intofriedow:mainfrom
async-trait in favor of native RPITIT#261a-kenji wants to merge 1 commit intofriedow:mainfrom
Conversation
The `async-trait` crate is no longer needed since Rust 1.75 stabilized return-position impl trait in traits ([RPITIT]). This eliminates the per-call heap allocation from boxing futures while keeping the same behavior. This is slightly less ergonomic, since it's now using static dispatch and the trait can't be dynamically dispatched anymore. [RPITIT]: https://rustc-dev-guide.rust-lang.org/return-position-impl-trait-in-trait.html
a-kenji
force-pushed
the
ke-impl-async-trait
branch
from
e6453b5 to
a63c4ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
async-traitcrate is no longer needed since Rust 1.75 stabilizedreturn-position impl trait in traits (RPITIT).
This eliminates the per-call heap allocation from boxing futures while keeping the same behavior.
This is slightly less ergonomic, since it's now using static dispatch and the trait can't be dynamically dispatched anymore.