WIP READ NB BELOW: WEBVIEW: Add dedicated UnsupportedBrowser controller to cacth WebView browsers#40
Open
friendlyantz wants to merge 13 commits intomasterfrom
Open
WIP READ NB BELOW: WEBVIEW: Add dedicated UnsupportedBrowser controller to cacth WebView browsers#40friendlyantz wants to merge 13 commits intomasterfrom
friendlyantz wants to merge 13 commits intomasterfrom
Conversation
Unfortunatly maskable option is out of play since multiple icons break android app installation, and instead it renders processed it's own icon which crops and removes transparent background
new:6 Error connecting controller
TypeError: Cannot read properties of null (reading 'addEventListener')
at Object.registerInteractionHandler (mdc.textfield.js:4067:37)
at MDCRippleFoundation.registerRootHandlers_ (mdc.textfield.js:2549:40)
at MDCRippleFoundation.init (mdc.textfield.js:2405:18)
at MDCRipple.MDCComponent (mdc.textfield.js:363:43)
at new MDCRipple (mdc.textfield.js:1966:51)
at rippleFactory (mdc.textfield.js:3543:24)
at MDCTextField.createRipple_ (mdc.textfield.js:4075:20)
at MDCTextField.initialize (mdc.textfield.js:3632:45)
at MDCTextField.MDCComponent (mdc.textfield.js:357:42)
at new MDCTextField (mdc.textfield.js:3533:46)
{identifier: 'textfield', controller: t, element: div}
…er to cacth WebView browsers This seems like adding unneccessary complexity to capture telegram/Webview refresh and saving the url I think we are better off detecting WebView early and guiding users to normal browser from the beginning We have WebAuthn dedicated alert though, another commit that i think we will progress with implements simple global webview helper method, which in this case seems like a sane solution for now While working on local, Telegram Webview in prod still have issues with navigating the links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP READ NB BELOW: WEBVIEW: Add dedicated UnsupportedBrowser controller to cacth WebView
This seems like adding unneccessary complexity to capture
telegram/Webview refresh and saving the url
I think we are better off detecting WebView early and guiding users to
normal browser from the beginning
We have WebAuthn dedicated alert though, another commit that i think we
will progress with implements simple global webview helper method, which
in this case seems like a sane solution for now
While working on local, Telegram Webview in prod still have issues with navigating the links