Conversation
frissyn
added
tag: enhancement
Owner
Author
|
Forgot about this cuz of end-of-semester grades lol, will get back on this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes aim to re-introduce asynchronous request functionality to valorant.py. The original implementation was naïve and still made blocking requests to the API.
This will add the
aiohttpdependency, and while I did want to keep the library dependency free for as long as possible, this functionality is too crucial to ignore.The
AsyncClientand its components will be introduced inv1.1.0, and other working changes will be added tov1.0.xin the meantime.Developement:
WebCallerto be more resource efficent.AioCallerclient usingaiohttp.Retry-Aftersupport.Provide async helper utilities?