Fc 51 fixed

[RAPTOR7762]

No description provided.

[RAPTOR7762]

Still working on it

[RAPTOR7762]

Work in progress

[RAPTOR7762]

@KjellMorgenstern Retried update

[RAPTOR7762]

@KjellMorgenstern anything that can be done to solve the problem?

[KjellMorgenstern]

Please use the check part script, the latest version is currently on the 1.0.5 branch for new parts:
https://github.com/fritzing/fritzing-parts/blob/1.0.5/scripts/checks/fzp_checker_runner.py

This is the same script that runs during the automated CI checks.
For some of the detected errors, there are automatic fixes available (pass the --fix option).

However, for the fcv-51 sensor, (and many of Peter Van Epps parts) the invisible connectors are not a direct problem. They only cause trouble in case the part has a different problem, or is re-used as an example to create a new part. The issue is, since the connectors are not visible (only through secondary visible elements), we get many new parts with invisible leftovers, which is very difficult to detect, and can cause wired effects.

[RAPTOR7762]

OK, @KjellMorgenstern I have changed the colour from None to #787878 to prevent ghost connectors for terminalIDs and pinIDs

Once this is completed, we can add this to https://github.com/fritzing/fritzing-parts/tree/1.0.5

[RAPTOR7762]

@KjellMorgenstern Any updates?

[RAPTOR7762]

Hi @KjellMorgenstern Are you going to merge this?

[RAPTOR7762]

Thanks Kjell! You going to run the workflow?

[RAPTOR7762]

Hi Kjell

Since this is my first time contributing a part here some confirmations:

I looked at the error logs and saw

Error: Property 'part number' has an empty value.
Error: Property 'layer' has an empty value.
Error: Property 'hole size' has an empty value.
Error: Property 'mn' has an empty value.
Error: Property 'mpn' has an empty value.

Wait their not supposed to be empty?

Error: Layer ID 'icon' from iconView not found in SVG file ./svg/core/icon/fc-51_2.svg

Do they cause any big problems? They still render in Fritzing tho

In another check

Run python scripts/connectors_misnumbered.py -d .
./obsolete/sparkfun-electromechanical-relay-2-g5q.fzp False True
<connector id="connector5" name="10" type="male">
<connector id="connector2" name="5" type="male">
<connector id="connector3" name="6" type="male">
<connector id="connector4" name="9" type="male">

2[11](https://github.com/fritzing/fritzing-parts/actions/runs/15817993044/job/44580563866?pr=415#step:8:12)5 files checked
Error: Process completed with exit code 255.

What does this mean

[KjellMorgenstern]

Error: Property 'part number' has an empty value.
Error: Property 'layer' has an empty value.
Error: Property 'hole size' has an empty value.
Error: Property 'mn' has an empty value.
Error: Property 'mpn' has an empty value.

Wait their not supposed to be empty?

It depends on the property, usually not.
You can check the inspector how the properties are applied.
Screenshot from the old FC 51 "

The hole size can't be modified, so you might as well remove it.
For the part number, mn, mpn . Without a value, listing these properties in the part will have no effect.
If you provide a default value, it should actually show, but this isn't used much yet.

Error: Layer ID 'icon' from iconView not found in SVG file ./svg/core/icon/fc-51_2.svg

Do they cause any big problems? They still render in Fritzing tho

This usually happens if you use the breadboard image as icon. This is often not the best solution, because the breadboard image is difficult to recognize at icon size. It is better to have a separate icon file, showing some characteristic region of interest, like a cropped version of the breadboard image.

In another check

Run python scripts/connectors_misnumbered.py -d .
./obsolete/sparkfun-electromechanical-relay-2-g5q.fzp False True
<connector id="connector5" name="10" type="male">
<connector id="connector2" name="5" type="male">
<connector id="connector3" name="6" type="male">
<connector id="connector4" name="9" type="male">

2115 files checked
Error: Process completed with exit code 255.

What does this mean

This is just the CI telling us that some error has happened before.

[RAPTOR7762]

Like maybe a blue board and the IR LEDs?

[RAPTOR7762]

Anyway I'll open another PR -- this is in a very big mess!