My teachers and tabbed buckets #5
Conversation
Two snippets: Site icon displays a site's icon as its image Assignment List lists out the assignments for a student without them accessing the app
Site icon as image & Assignment list
and improved site icon code based on feedback
Added correct code for assignments
Site icon is commented, assignments list rewritten for student accessing latest assignments
Updated based on feedback
Updated to tidy up styling and add comments
Added some a third snipped based on a school's request
|
|
||
| /// Get all the groups assoicated with logged in user | ||
| Frog.Model.api('users.getDataInCategory', { | ||
| user_uuid:user.uuid, |
There was a problem hiding this comment.
Why are we not using .attr().
user_uuid: user.attr('uuid')
|
Formatting is inconsistent and incorrect in most places. Grammar (especially comments) is incorrect in several files. The diff also contains the assignment-list snippet which was merged last week. Please ensure your folk is up-to-date with |
|
I think we need to review how you use GIT. The desktop application does hide some of the complexities but it also prescribes you to a workflow that is fairly restrictive and confusing. I think you will understand the CLI and it will allow for easier management. Let me know if you are comfortable with this and I can set something up to go through it with you |
|
Hi Chris, Thank you. And yes to all your suggestions. Are you free this afternoon? Or anytime this week? Graham From: Chris Smith [mailto:notifications@github.com] I think we need to review how you use GIT. The desktop application does hide some of the complexities but it also prescribes you to a workflow that is fairly restrictive and confusing. I think you will understand the CLI and it will allow for easier management. Let me know if you are comfortable with this and I can set something up to go through it with you — |
Site icon as image & Assignment list
2 participants
Two new snippets.