fix: add placeholder script folder & update foundry.toml#43
fix: add placeholder script folder & update foundry.toml#43frolic merged 1 commit intofrolic:mainfrom
Conversation
|
I can make a PR and add the forge deploy script I added, which honestly is
based off of what Sam posted in discord. It uses Solenv, which currently
isn’t in this project.
The one issue I ran into was that the output is very different than the
simple json files you get using “forge create” and so I have to manually
update the json files in the deploy folder for now.
|
|
@TheRightChoyce definitely curious to see that! If we end up proceeding with #10, maybe we can just use the Forge JSON output for deployment logging. I assume it has the same info as the bash script (deployer, deployed address, and transaction hash). On a related note I've been thinking about the JSON structure through #27, specifically this line: https://github.com/holic/web3-scaffold/pull/27/files#diff-faacf75568c5be11b2ca5003bf27d181bbe5fda8995a4183444c5fa0df142678R1 I think we should move the |
|
The default output from the broadcasts are way more verbose. I was going to post an example but its a lot to grok through. I can block some time tomorrow to do a PR with the deploy.sol script! |
|
Thank you! |
Adds a placeholder
scriptfolder and fixes reported issue with compiling from a script.