🧹 extract duplicated report printing logic into a helper function#4
🧹 extract duplicated report printing logic into a helper function#4
Conversation
…tion Extracted the console report printing logic in `claw2manus/cli.py` into a new private helper function `_print_conversion_report`. This reduces code duplication in `convert_skill` and `fetch_and_convert_skill`, improving maintainability. Co-authored-by: frostmute <989225+frostmute@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI by extracting the conversion report printing logic into a new helper function, _print_conversion_report, to eliminate code duplication across convert_skill and fetch_and_convert_skill. The reviewer suggested adding type hints to the new function's signature to improve code clarity and maintainability.
| user_input = input("Enter custom instruction (or press Enter to use default): ").strip() | ||
| return user_input if user_input else default_instruction | ||
|
|
||
| def _print_conversion_report(report): |
There was a problem hiding this comment.
The new helper function _print_conversion_report is missing type hints. Adding them improves code clarity and maintainability, especially since other functions in this file (like convert_skill) already use them. Following PEP 484 and PEP 8 recommendations, it's best practice to annotate function signatures in modern Python code.
| def _print_conversion_report(report): | |
| def _print_conversion_report(report: list[str]) -> None: |
References
- PEP 8 and PEP 484 encourage the use of type hints for new code to improve readability and allow for static analysis. (link)
1 participant
🎯 What: Extracted duplicated report printing logic into a shared helper function
_print_conversion_report.💡 Why: This improves maintainability by reducing code duplication and centralizing the report format in one place.
✅ Verification: Verified through:
claw2manus/cli.pyusingast.parse._print_conversion_reportproduces the expected output for both filled and empty reports.✨ Result: Reduced code duplication in
claw2manus/cli.py.PR created automatically by Jules for task 14060629211983025347 started by @frostmute