feat(mentat): improve skill generation prompt#22
Closed
Conversation
… practices - Rewrite buildPrompt(): ~50% shorter, example-driven, no prescriptive section headers. One-shot 'queue' domain example shows the target quality. Domain context condensed to a single header line. - Simplify normaliseContent(): remove fragile \n---\n mid-content heuristic; keep code-fence stripping and trailing stats-line stripping. - Add generator_internal_test.go: 14 new unit tests covering all prompt properties (domain context, frontmatter, example presence, no rigid sections, empty-sample guard) and all normaliser edge cases (fences, stats, mid-HR, empty input, trailing newline). Exec plan: docs/exec-plans/completed/mentat-writing-skills-prompt.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites
buildPrompt()in the mentat generator based on Anthropic's skill authoring best practices, and simplifiesnormaliseContent().Changes
buildPrompt()— ~50% shorter, example-drivennormaliseContent()— simplified\n---\nheuristic that could silently truncate mid-document content (e.g. when a horizontal rule appears in the body)generateWith(unchanged)New tests:
generator_internal_test.go14 unit tests covering:
Verification