refactor: Distinguish semanage 'already exists' from real failures#126
Open
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Open
refactor: Distinguish semanage 'already exists' from real failures#126frostyardyeti[bot] wants to merge 1 commit intomainfrom
frostyardyeti[bot] wants to merge 1 commit intomainfrom
Conversation
The semanage fcontext error was unconditionally swallowed, silencing genuine failures like missing SELinux tools or permission denied. Now only suppress the error when the output contains 'already defined' or 'already exists', and return the error for all other failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
need someone with SELinux to review/validate |
Contributor
Author
|
— Automated by Yeti — No code changes needed. The review comment from @bketelsen is not requesting a code change — it's flagging that the PR needs validation from someone with SELinux experience before merging. The change itself is straightforward and correct:
This matches |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
internal/provision/provision.go:330-334, thesemanage fcontext -aerror is unconditionally swallowed with_ = errand a comment that it may mean 'already defined'. However, this also silences genuine failures like missing SELinux tools or permission denied errors. The fix is to check the command output/stderr for 'already defined' or 'already exists' and only suppress that specific case, returning the error for other failures.Automated improvement by yeti improvement-identifier