refactor: Return unexpected errors from IsActive and IsEnabled#107
Merged
refactor: Return unexpected errors from IsActive and IsEnabled#107
Conversation
The fallthrough error paths in both functions returned false, nil for all errors, silently swallowing failures like systemctl not found, permission denied, or unknown exit codes. Change to return false, err so callers can distinguish "unit is not active/enabled" from "we couldn't determine the state". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bketelsen
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
systemd/runner.go, bothIsActive(line 52) andIsEnabled(line 67) returnfalse, nilfor all errors after checking for expected exit codes. This silently swallows unexpected failures such assystemctlnot being found on$PATH, permission denied, or unknown exit codes.For example in
IsActive(lines 42-55), after handling exit code 3 (inactive), the fallthroughreturn false, nilon line 52 hides any other error. The same pattern on line 67 inIsEnabledhides errors beyond exit code 1.The fix: change the fallthrough
return false, niltoreturn false, errin both functions so callers can distinguish between "unit is not active" and "we couldn't determine the state".Automated improvement by yeti improvement-identifier