refactor: Extract shared drop-in file creation from EnableFeature and DisableFeature#108
Merged
refactor: Extract shared drop-in file creation from EnableFeature and DisableFeature#108
Conversation
…sableFeature Both methods contained near-identical code for creating the drop-in directory, writing the drop-in file, and handling dry-run logging. The only difference was the content (Enabled=true vs Enabled=false). Extract a shared writeFeatureDropIn method to consolidate this logic. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
updex/features.go,EnableFeature(lines 112-136) andDisableFeature(lines 263-287) contain near-identical code for creating the drop-in directory, writing the drop-in file, and handling dry-run logging. The only difference is the content written (Enabled=truevsEnabled=false).Both blocks:
dropInDiranddropInFilepaths identicallyos.MkdirAll+os.WriteFilewith identical error handlingresult.DropInand log successExtract a helper like
writeFeatureDropIn(name string, enabled bool, dryRun bool) (string, error)to consolidate this logic and reduce the duplication.Automated improvement by yeti improvement-identifier