Skip to content

Releases: fs-webdev/eslint-config-tree

6.4.1

13 Oct 19:47
455e94e

Choose a tag to compare

  • Update md file and add package-lock.json (#27)

In the last pr, the master build failed because
eslint-config-frontier-react updated after the pr was made, but before
it was merged, and that update included a change to the test.

Add package-lock.json to see changes better and not have a pr's checks
be possibly different than the master's checks due to deps changing
things between a pr creation and merge.

@fs/eslint-config-frontier-react@11.4.2 turned off
you-dont-need-lodash-underscore/clone-deep and that made the test fail
on master.

  • Update snapshots based on new test rule settings (#28)

@fs/eslint-config-frontier-react@11.4.2 turned off
you-dont-need-lodash-underscore/clone-deep.

This fixes the master build.

6.4.0

13 Oct 15:24
58e1ddd

Choose a tag to compare

  • Add @eslint-community/eslint-comments dependency (#26)

@eslint-community/eslint-comments can replace
eslint-plugin-bestpractices as it is a community-wide eslint plugin.

https://eslint-community.github.io/eslint-plugin-eslint-comments/rules/
to see the rules.

The rule that specifically replaces the old
bestpractices/no-eslint-disable is require-description. It does
basically the same. The difference is that it only affects real
eslint-disable directives. For example, it doesn't affect // eslint-disable-next as that doesn't actually disable any linting rules.
See https://eslint.org/docs/latest/use/configure/rules.

The plugin adds its recommended rules automatically. Those rules are:
disable-enable-pair, no-aggregating-enable, no-duplicate-disable,
no-unlimited-disable, no-unused-disable, no-unused-enable. They are all
treated as errors. The only way to turn them off is to turn them off
individually as the plugin doesn't allow consumers to just get the
plugin and define which rules to turn on. I do think those rules are
nice to have though, so I think it is fine to keep them. I particularly
like the no-unlimited-disable to make developers be specific on what
they are disabling.

I updated the example test to do a common eslint disable directive
(eslint-disable-next-line) that actually disables a eslint rule on the
next line. This triggers both the
@eslint-community/eslint-comments/require-description and
@eslint-community/eslint-comments/no-unlimited-disable rules.

6.3.1

12 Sep 19:45
0fa1036

Choose a tag to compare

  • Update @fs/eslint-config-frontier-react (#25)

  • consume real version (11.4.0) of @fs/eslint-config-frontier-react

Use VsCode's diff instead of GitHub's to see the changes more clearly.

The stylistic rules are from v10 of eslint-config-prettier.

@fs/eslint-config-frontier-react@11.4.0 changelog:

  • Update deps
  • jest/no-disabled-tests warn -> error
  • Add cypress mocha linting rule

6.3.0

27 Mar 17:31
9f6b2b7

Choose a tag to compare

  • Add TS lint testing and @typescript-eslint/explicit-module-boundary-types warning (#24)

We want to use @typescript-eslint/explicit-module-boundary-types and will have it as a warning for now to not disrupt us as much. Later on we will make it an error.
This is the first TS rule we are adding in this configuration, therefore, the ts eslint config and a ts file for testing local eslint issues are now part of testing.

6.2.0

24 Mar 18:40
75610f0

Choose a tag to compare

  • Consume cypress rules from eslint-frontier-react-config/cypress (#23)
  1. npm update
  2. add frontier's cypress config for our es6 config so we can have that
    for our apps without specifying it in our apps. The cypress linting
    rules are specific to just cypress tests.
  3. update tests

6.1.1

30 Sep 15:33
082391b

Choose a tag to compare

  • Add cy files to our overrides for tests and non-production code to not include our extra rules that are not needed for that (#21)

For example, we don't need to add test selectors for buttons in our cy
tests.

This will make it so we don't see these warnings (and the like) in our
apps that will have cypress testing:

image

image

To-Dos

  • Run tests (part of pre-push hook)
  • Update demo and tests, if linting configuration is being changed
  • Update documentation & README
  • Increment package.json version

6.1.0

19 Sep 15:07
caa8a80

Choose a tag to compare

  • Support the new @fs/zion/logical-over-directional (#20)

To get the new @fs/zion/logical-over-directional rule to be applied.

@fs/zion/logical-over-directional is in the jest file for now.
jest stuff is in overrides in the jest file so we can just extend it
from the top level rather than from a overrides.

npm update and update to node 20 and update husky
npm run test:update

6.0.1

31 Jan 15:11
e126b72

Choose a tag to compare

  • UpdateQALintingRules (#19)

QA uses WDIO, and with some of the ways WDIO is formatted, we use unnamed functions as our it functions.
We CAN use arrow functions, but that kills the ability to use this in our tests. Which we use a lot.

  • [maintenance] Update CODEOWNERS

6.0.0

13 Dec 18:35
9cccc2e

Choose a tag to compare

  • npm update and cut the release like @fs/eslint-config-frontier-react (#18)

Updated because I saw that @fs/eslint-config-frontier-react had cut the
release.

my only concern is the new JSDoc description does not satisfy the regex.
@skye2k2 Could you take a look at that?


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

  • npm run test:update with latest deps (#17)

Nothing new has been changed in this repo--just updating deps to see
what changes in linting-config.test.js.md

  • Add shared linting configuration for QA acceptance tests (#16)

Description

Add shared configuration for our WDIO acceptance tests.
Add fixtures to the test overrides list where certain rules are disabled.

Changes

  • qa.js configuration added.
  • Release version 6.0.0-alpha.4.
  • Remove preinstall to see if that is causing issues with prerender-service (#15)

update @fs/eslint-config-frontier-react too, see
fs-webdev/eslint-config-frontier-react#38

This is the issue in prerender-service, so seeing if this will fix this.

image

  • Re-enable tests

NOTE: This build will fail. From now on, we should be reviewing new changes regularly and making informed decisions about the changes to various rules.

  • Add Travis CI-based publishing (#14)

Add .travis.yml configuration and @fs/npm-publisher dependency and build step.
Disable tests, to get an already-released version out to artifactory.

TODO: Review the rule changes, and cut a new release.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

  • Update cognitive-complexity number (#13)

Change cognitive-complexity back to 25 for most files
Make test files and such have complexity of 50

  • Update to latest eslint-config-frontier-react (#12)

See fs-webdev/eslint-config-frontier-react#37

  • v6-alpha (#11)

Major release: v6-alpha

Consume latest eslint-config-frontier-react.
Remove all Polymer-based, Code Climate-related, and legacy configuration and documentation.
Upgrade eslint to version 8.
Update snapshots to take all new rules into account.
Centralize all of our typical overrides (.ts, .stories, .test, etc.), and compartmentalize into its own es6.js file.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

  • Compare Final Config for Testing (#10)

Print out final eslint config with the rules sorted alphabetically.
Compare the config to the previous reason in a new test.
Clean up output files to strip out environment-specific data via node script, as sed was causing too many issues.
Update documentation.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

6.0.0-alpha.4

27 Apr 13:40
9169645

Choose a tag to compare

6.0.0-alpha.4 Pre-release
Pre-release
  • Add shared linting configuration for QA acceptance tests (#16)

Description

Add shared configuration for our WDIO acceptance tests.
Add fixtures to the test overrides list where certain rules are disabled.

Changes

  • qa.js configuration added.
  • Release version 6.0.0-alpha.4.
  • Remove preinstall to see if that is causing issues with prerender-service (#15)

update @fs/eslint-config-frontier-react too, see
fs-webdev/eslint-config-frontier-react#38

This is the issue in prerender-service, so seeing if this will fix this.

image

  • Re-enable tests

NOTE: This build will fail. From now on, we should be reviewing new changes regularly and making informed decisions about the changes to various rules.

  • Add Travis CI-based publishing (#14)

Add .travis.yml configuration and @fs/npm-publisher dependency and build step.
Disable tests, to get an already-released version out to artifactory.

TODO: Review the rule changes, and cut a new release.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

  • Update cognitive-complexity number (#13)

Change cognitive-complexity back to 25 for most files
Make test files and such have complexity of 50

  • Update to latest eslint-config-frontier-react (#12)

See fs-webdev/eslint-config-frontier-react#37

  • v6-alpha (#11)

Major release: v6-alpha

Consume latest eslint-config-frontier-react.
Remove all Polymer-based, Code Climate-related, and legacy configuration and documentation.
Upgrade eslint to version 8.
Update snapshots to take all new rules into account.
Centralize all of our typical overrides (.ts, .stories, .test, etc.), and compartmentalize into its own es6.js file.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org

  • Compare Final Config for Testing (#10)

Print out final eslint config with the rules sorted alphabetically.
Compare the config to the previous reason in a new test.
Clean up output files to strip out environment-specific data via node script, as sed was causing too many issues.
Update documentation.


Co-authored-by: Clif Bergmann cbergmann@familysearch.org