[FEATURE]: Top News: Internal Team News Feed#82
Open
ddre54 wants to merge 8 commits intofscbco:mainfrom
Open
Conversation
- Add "Know How" environment setup instructions - Update `config/environments/test.rb` to use the new db connection handling according to deprecation warnings
- Setup rspec to use factories with `factory_bot` - Setup rspec to use devise helper methods with `devise` - Introduce `spec/support` directory for gem configuration with rspec - Introduce `spec/factories` directory for model factories in rspec using `factory_bot` - Implements "Users should sign in and out"
- Add lib/services directory to locate files that deal with third-party integrations - Implement HackerNews client to deal with the requests of the stories - Add tests to ensure they work in a predictable way
- Add models to stored the required created articles - Add models to stored the favorited articles per user - Add tests
- Add Articles controller to list top stories - Add HackerNews conversion from stories to new Articles - Add shared_context for rspec TODO: - [ ] Refactor shared_examples for `without sign in user` on request tests - [ ] Add link to action to allow Users to pick articles - [ ] Add Team Articles list view
- Allows to pick Articles from "Top News" - Adds "Team Article" functionality with who picked it - Refactors factories to be usable multiple times - Add tests to new functionality TODO: - [ ]: Modify `article.external_id` column from string to int - [ ]: Refactor some of the views into partials - [ ]: Improve UX/UI to display the information. Improve user feedback on actions. - [ ]: Add capability to remove "pick" article from "Team Articles"
- Change column external_id type in articles from string to integer TODO: - [ ]: Add Dockers to run environment - [ ]: Add cache layer in articles#index for HackerNews stories
- Add Docker to run development environment - Add Docker to run tests and test environment - Add README.md instructions on how to use docker commands setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FEATURE]: Top News: Internal Team News Feed
Notes: