Conversation
…ads and caches image_futures in album; some minor improvements
… a locale change button in login_ui; added time localization in various places (only for months); refactored single_news for both locales; some other minor improvements
georgelgeback
requested changes
Feb 18, 2026
Contributor
georgelgeback
left a comment
georgelgeback
left a comment
There was a problem hiding this comment.
LGTM other than one translation which needs fixing.
lib/l10n/app_en.arb
Outdated
| "resetEmail": "Email", | ||
| "resetSubmit": "Submit", | ||
| "resetValidate": "Please input an email", | ||
| "resetDone": "Your password has been reset. An email has been sent with your new password.", |
Contributor
There was a problem hiding this comment.
On frontend web this is "If your email exists, a reset link has been sent.", which is more in line with what happens.
lib/l10n/app_sv.arb
Outdated
| "resetEmail": "Email", | ||
| "resetSubmit": "Skicka", | ||
| "resetValidate": "Skriv en email", | ||
| "resetDone": "Ditt lösenord has återställts. Ett mail har skickats med ditt nya lösenord.", |
Contributor
There was a problem hiding this comment.
Same thing here as in the english file
Contributor
There was a problem hiding this comment.
Pls regenerate these after so the old translations are not stuck
…tch the web counterpart and to be clearer
Contributor
Author
|
Fixed it! Also changed some other localizations to match the web counterpart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kanske för mycket för en pull request? Gör i alla fall så man kan markera och ladda ner flera bilder samt några localizations (både text och tid). Det mest märkbara är att login_ui är localized men det finns en knapp för att togglea locale. Har testat det mesta tror jag.