Skip to content

Some html encodes added (to prevent XSS) #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nojaf merged 1 commit into from
Oct 29, 2025
Merged

Some html encodes added (to prevent XSS) #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/FSharp.Formatting.Markdown/HtmlFormatting.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ let rec internal formatSpan (ctx: FormattingContext) span =
// use mathjax grammar, for detail, check: http://www.mathjax.org/
ctx.Writer.Write("<span class=\"math\">\\(" + (htmlEncode body) + "\\)</span>")

| AnchorLink(id, _) -> ctx.Writer.Write("<a name=\"" + id + "\">&#160;</a>")
| AnchorLink(id, _) -> ctx.Writer.Write("<a name=\"" + htmlEncodeQuotes id + "\">&#160;</a>")
| EmbedSpans(cmd, _) -> formatSpans ctx (cmd.Render())
| Literal(str, _) -> ctx.Writer.Write(str)
| HardLineBreak(_) -> ctx.Writer.Write("<br />" + ctx.Newline)
Expand Down Expand Up @@ -181,7 +181,8 @@ let rec internal formatParagraph (ctx: FormattingContext) paragraph =

if ctx.GenerateHeaderAnchors then
let anchorName = formatAnchor ctx spans
ctx.Writer.Write(sprintf """<a name="%s" class="anchor" href="#%s">""" anchorName anchorName)
let safeAnchorName = htmlEncodeQuotes anchorName
ctx.Writer.Write(sprintf """<a name="%s" class="anchor" href="#%s">""" safeAnchorName safeAnchorName)
formatSpans ctx spans
ctx.Writer.Write "</a>"
else
Expand Down Expand Up @@ -210,7 +211,7 @@ let rec internal formatParagraph (ctx: FormattingContext) paragraph =
if String.IsNullOrWhiteSpace(language) then
ctx.Writer.Write(sprintf "<pre><code>")
else
let langCode = sprintf "language-%s" language
let langCode = sprintf "language-%s" (htmlEncodeQuotes language)
ctx.Writer.Write(sprintf "<pre><code class=\"%s\">" langCode)

ctx.Writer.Write(htmlEncode code)
Expand Down