Conversation
|
What's the way to test if what I've done works? There are no docs what so ever about how to run this thing in dev mode...? |
|
good question. did not do this for very long time. probably by copying things manually in place |
|
While you have a look at that, here are the main changes:
This will make it:
QA needed on:
Help needed on:
AFK for a while now; I need to write my presentation too. Which btw I could hold for the F# community too; intro to Kafka. |
|
upgrading reveal was always easy. https://github.com/fsprojects/FsReveal/blob/develop/paket.dependencies#L6 |
|
I did notice a strange |
|
suave is taken via paket from nuget. |
|
|
||
| The node modules take care of bundling all the JS dependencies. You don't need | ||
| anything other than Yarn to compile, but some of them are dependent on having a | ||
| binary called 'python2' on your PATH. |
There was a problem hiding this comment.
Yup, the wonderful world of JS dev
There was a problem hiding this comment.
I don't know. JS pulls in the world and I'm using the "standard" setup for css/html.
README.md
Outdated
| `./src/FsReveal/template.{html,js}` is the entry point for webpack during | ||
| packaging. | ||
|
|
||
| When you've performed a change to the repo, it's all packaged as a nuget. That |
There was a problem hiding this comment.
"as a NuGet package. That package..."
README.md
Outdated
| # npm install -g yarn | ||
| yarn install --ignore-engines | ||
| yarn run build | ||
| # when you wanna test your changes: |
README.md
Outdated
| ### Dev | ||
|
|
||
| ``` | ||
| pyenv local 2.7.10 |
|
@kimsk @troykershaw What css file am I missing? Only getting white BG: |
|
It looks like the |
|
@kimsk Thanks; the last two issues are:
|
|
I've just tested this on my MacBook, and here are my findings:
ERROR in ./template.js Module not found: Error: Cannot resolve 'file' or 'directory' ../../paket-files/fsprojects/reveal.js/css/reveal.css in /Users/erikschierboom/Programming/FsReveal/src/FsReveal @ ./template.js 3:0-64 43:2-66 Having run
|
|
You need to run Suave like in my screenshots above... Could you do that? |
|
@haf Sorry, but how do I do that? If I run a local node I'm a bit confused a to why Suave would be necessary. Wasn't the whole point being that it could run offline? |
|
Yes, it runs offline from the point of view of your laptop. Just because we start a local web server, we don't have internet. Today we can't show the presentation without internet. I'll see what I can whip together in the form of a readme. |
|
@haf Okay, clear. But shouldn't running A readme would be much appreciated! |
|
I've updated the READMEs with that information now @ErikSchierboom |
|
How to test: check out the two branches. First build this PR with |
|
I think it's worth merging now and fixing remaining issues together with the community: e.g. the pretty-printed code lines being slightly off, bumping |
|
Thanks @haf! |
|
Any chance of this? |
|
Need someone to pick up the slack. I don't have the bandwidth to complete this refactor (but it's working now, so someone just needs to merge it and test it in full) |





The aim of the PR is to make FsReveal function without internet access. This means we need to pull in all of the code as a single compilation unit: