modified generated HTML files by downloading CDN-loaded assets#105
Closed
wki wants to merge 1 commit intofsprojects:masterfrom
wki:master
Closed
modified generated HTML files by downloading CDN-loaded assets#105wki wants to merge 1 commit intofsprojects:masterfrom wki:master
wki wants to merge 1 commit intofsprojects:masterfrom
wki:master
Conversation
|
This would be awesome, it's something I've wanted solved for ages! |
Member
|
@haf howdoes this relate to your recent work? |
Member
|
It's duplicate work to my PR. |
Author
|
if this thing will be solved by another PR, then please silently ignore my PR. |
Member
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
maybe I am doing something wrong. But when opening generated HTML files in the output-directory directly in a browser fails because some JavaScript or CSS Assets are loaded without a protocol. This requires being online when viewing a presentation and requires starting a server.
By downloading all CDN-loaded assets into the output-directory, all presentations may be viewed offline and without running a web server.
This simple patch modifies the HTML files after their generation. Maybe not perfect but usable.
Forgive me if my beginners-F#-Style is not perfect, too.