Refactor methods, and also add "super" support for "spooked" and "job"#7
Closed
jack126guy wants to merge 2 commits intofsufitch:masterfrom
Closed
Refactor methods, and also add "super" support for "spooked" and "job"#7jack126guy wants to merge 2 commits intofsufitch:masterfrom
jack126guy wants to merge 2 commits intofsufitch:masterfrom
Conversation
The various commands differ primarily in the command name and the text printed. Add a method "print_text" to handle most of the formatting, and have the other methods call that.
Author
|
The diff for the refactoring is messy, and I also didn't want to have two things in the same PR. I've opened a new one at #8 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there was no "super" version of the message for "git spooked" and "git job", so I decided to add them. I then noticed that a lot of the code was duplicated, so I refactored it into a common printing method. (Maybe this should be two pull requests?)
This is probably my first time actually coding Python 😮 Please let me know if I should fix some things.