Skip to content

feat(contracts): fork mainnet in the tests#36

Draft
igorline wants to merge 6 commits intomainfrom
mainnet-fork
Draft

feat(contracts): fork mainnet in the tests#36
igorline wants to merge 6 commits intomainfrom
mainnet-fork

Conversation

@igorline
Copy link
Copy Markdown
Contributor

@igorline igorline commented Jun 7, 2022

No description provided.


const { smallStrikePrice, bigStrikePrice } = await strategy.getStrikes();
console.log(smallStrikePrice.toString(), bigStrikePrice.toString());
// const { smallStrikePrice, bigStrikePrice } = await strategy.getStrikes();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baraa42 I don't have such a method, so I had to comment this

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorline was just testing it selects strikes correctly, works ok

mintargetDelta: toBN("0.15"),
maxtargetDelta: toBN("0.85"),
maxDeltaGap: toBN("0.05"), // accept delta from 0.10~0.20 or 0.80~0.90
// maxDeltaGap: toBN("0.05"), // accept delta from 0.10~0.20 or 0.80~0.90
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you removed this @Baraa42 ?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorline we don't use it in the strategy, and you asked to remove redundant vars

@igorline
Copy link
Copy Markdown
Contributor Author

igorline commented Jun 7, 2022

@Baraa42, here the test is failing with error: Not approved to act on behalf. This happens when you are trying to trade premiums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants