Skip to content

Add error checking around dynamo update #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanchard wants to merge 1 commit into
base: serverless
Choose a base branch
from
Open

Add error checking around dynamo update #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions aws/action-status.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import sys
import json
import boto3
import decimal
Expand Down Expand Up @@ -49,10 +50,12 @@ def lambda_handler(event, context):

task_results = json.loads(action_record['tasks'])
# Find the taskIDs where the results are not yet in
running_tasks = list(filter(lambda task_id: bool(task_id),
[key if not task_results[key][
'completed'] else False
for key in task_results.keys()]))
running_tasks = None
if task_results:
running_tasks = list(filter(lambda task_id: bool(task_id),
[key if not task_results[key][
'completed'] else False
for key in task_results.keys()]))

status = "SUCCEEDED"
display_status = "Function Results Received"
Expand All @@ -76,22 +79,29 @@ def lambda_handler(event, context):
task_results[task]['result'] = result
task_results[task]['completed'] = completed

update_response = table.update_item(
Key={
'action-id': action_id
},
UpdateExpression="set tasks=:t",
ExpressionAttributeValues={
':t': json.dumps(task_results, cls=DecimalEncoder)
},
ReturnValues="UPDATED_NEW"
)
try:
update_response = table.update_item(
Key={
'action-id': action_id
},
UpdateExpression="set tasks=:t",
ExpressionAttributeValues={
':t': json.dumps(task_results, cls=DecimalEncoder)
},
ReturnValues="UPDATED_NEW"
)
except Exception as eek:
print("Failed to update dynamodb: ", eek)
status = "FAILED"
display_status = "Function Failed"
failure = "Failed to record function result: " + str(eek)

print("updated_response", update_response)
if failure:
print("FAILED ", failure)
status = "FAILED"
display_status = "Function Failed"
details = failure
else:
status = "ACTIVE"
display_status = "Function Active"
Expand Down