Skip to content

handle upload events happening after destruction #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BryanCrotaz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle upload events happening after destruction #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions addon/components/file-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,11 @@ export default Component.extend({
},

addPreviewImage: function(file) {
// called by readFile callback, so we could have been destroyed
if (this.isDestroyed || this.isDestroying) {
return;
}

var image = this.$(
'<img src="' + file.data + '" class="file-picker__preview__image ' +
(this.get('multiple') ? 'multiple' : 'single') + '">');
Expand All @@ -132,6 +137,10 @@ export default Component.extend({
},

updateProgress: function(event) {
// called by readFile callback, so we could have been destroyed
if (this.isDestroyed || this.isDestroying) {
return;
}
const {
loaded,
total
Expand Down