Skip to content

Conversation

@vinaypuppal
Copy link
Contributor

This reduces bundled app.js size from 271KB to 143KB

Before:
screen shot 2017-07-11 at 9 13 04 pm

After:
screen shot 2017-07-11 at 9 14 23 pm

@vinaypuppal
Copy link
Contributor Author

vinaypuppal commented Jul 11, 2017

And also added webpack-bundle-analyzer so we can see what is included in production bundles

You can run it using yarn analyze or npm run analyze it will show something like this

screen shot 2017-07-11 at 9 25 48 pm

If you want to why some library is included in some bundle for eg: Why create-react-class is included in common.js bundle
You can know why easily by running yarn why create-react-class and it tells you

info This module exists because "react-ga" depends on it.

@JesseRWeigel
Copy link
Contributor

For some reason I am getting an error saying that r is not a function on app.js line 7 when I try to run this in production mode on a server. Any idea what I could be doing wrong?

@vinaypuppal
Copy link
Contributor Author

@JesseRWeigel To which branch did you merge this? I just pulled new-resource-ui in to this and builded locally it was successful. And i also deployed to now.sh its working https://ci-react-hfnvacdbzk.now.sh

@vinaypuppal vinaypuppal changed the base branch from master to dev July 12, 2017 18:13
@vinaypuppal
Copy link
Contributor Author

And also Changed base branch to dev instead of master

@JesseRWeigel
Copy link
Contributor

@vinaypuppal Thanks for checking into this. I will try it again when I get a chance.

@JesseRWeigel
Copy link
Contributor

I have been pull from this project onto another one. I am supposed to come back to this project to make updates in October. I will try to merge this then. Thanks @vinaypuppal !

@vinaypuppal
Copy link
Contributor Author

oh okay, no problem. Thanks for update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants