Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Fix translations endpoint in development for named chunks#216

Merged
rtsao merged 1 commit intomasterfrom
i18n-dev
Apr 4, 2019
Merged

Fix translations endpoint in development for named chunks#216
rtsao merged 1 commit intomasterfrom
i18n-dev

Conversation

@rtsao
Copy link
Copy Markdown
Contributor

@rtsao rtsao commented Apr 4, 2019

In development, chunk ids may have string names.

This fixes the following failing e2e test: fusionjs/fusion-cli#754

@rtsao rtsao changed the title Correctly handle named chunks Fix translations endpoint in development for named chunks Apr 4, 2019
@rtsao rtsao added the bugfix label Apr 4, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2019

Codecov Report

Merging #216 into master will decrease coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   86.08%   85.47%   -0.62%     
==========================================
  Files           5        5              
  Lines         115      117       +2     
  Branches       28       29       +1     
==========================================
+ Hits           99      100       +1     
  Misses         10       10              
- Partials        6        7       +1
Impacted Files Coverage Δ
src/node.js 88% <66.66%> (-1.59%) ⬇️
src/index.js 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a73d7...2023967. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2019

Codecov Report

Merging #216 into master will decrease coverage by 0.61%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   86.08%   85.47%   -0.62%     
==========================================
  Files           5        5              
  Lines         115      117       +2     
  Branches       28       29       +1     
==========================================
+ Hits           99      100       +1     
  Misses         10       10              
- Partials        6        7       +1
Impacted Files Coverage Δ
src/node.js 88% <66.66%> (-1.59%) ⬇️
src/index.js 75% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a73d7...2023967. Read the comment docs.

@rtsao rtsao merged commit c9f3588 into master Apr 4, 2019
@old-fusion-bot
Copy link
Copy Markdown

old-fusion-bot bot commented Apr 4, 2019

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1829

@old-fusion-bot old-fusion-bot bot deleted the i18n-dev branch April 4, 2019 18:10
@ganemone ganemone mentioned this pull request Apr 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants