Skip to content
This repository was archived by the owner on May 17, 2019. It is now read-only.

Improve API for getSimulator#120

Open
alxmyth wants to merge 2 commits intofusionjs:masterfrom
alxmyth:improve-api-for-get-simulator
Open

Improve API for getSimulator#120
alxmyth wants to merge 2 commits intofusionjs:masterfrom
alxmyth:improve-api-for-get-simulator

Conversation

@alxmyth
Copy link
Copy Markdown
Member

@alxmyth alxmyth commented May 18, 2018

Consistency with getService (link)

@alxmyth alxmyth self-assigned this May 18, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented May 18, 2018

Codecov Report

Merging #120 into master will increase coverage by 1.7%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #120     +/-   ##
=========================================
+ Coverage   87.69%   89.39%   +1.7%     
=========================================
  Files           3        3             
  Lines          65       66      +1     
  Branches        8        8             
=========================================
+ Hits           57       59      +2     
+ Misses          6        5      -1     
  Partials        2        2
Impacted Files Coverage Δ
src/index.js 75.86% <100%> (+0.86%) ⬆️
src/mock-context.js 100% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94de7f5...95021f1. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant