Add support for SetExtendedColorZones #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @futomi, would you be open to reviewing or discussing this PR? Sam |
Author
|
Hi @futomi, I was circling back to this and noticed you had some activity on this remote again. I updated my pull request here to resolve the small merge conflict. Would you be open to including this? The I have included documentation for the new method consistent with yours in the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new(-ish)
SetExtendedColorZones(510) message type for compatible products (e.g. LIFX Z Strip, LIFX BEAM).See the README.md diff for an example of how this works. I tried to work within the conventions of your codebase.
Sam