PR de correção #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inicio enviar msg
eslint e styled-components add
This reverts commit ec0c868.
mensagens listadas, input funcionando
Projeto terminado
BrunoMovio
commented
Jan 5, 2021
Author
BrunoMovio
left a comment
BrunoMovio
left a comment
There was a problem hiding this comment.
Boa tarde Gabriel e Victor!
O projeto foi avaliado como: dentro do esperado.
O layout ficou muito bom, porém os campos de input de remetente e conteúdo possuem o mesmo tamanho, e estão um acima do outro (e não ao lado). Outro ponto a ser levantado é a organização do código: a componentização ficou show, mas seria mais adequado separar alguns dos componentes que estão no App.js, para que sejam arquivos menores e mais fáceis de depurar!
No restante, só tenho os parabéns a dar pela entrega, mandaram muito bem!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.