PR de correção #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funcionalidade
Realizado a parte do exercício
Implementação do Layout | WhatsApp Web
Projeto quase finalizado
Projeto WhatsLab Finalizado
BrunoMovio
commented
Jan 5, 2021
Author
BrunoMovio
left a comment
BrunoMovio
left a comment
There was a problem hiding this comment.
Boa tarde Allison e José!
O projeto foi avaliado como: acima do esperado!
Parabéns pela entrega! O projeto ficou realmente muito bom, com quase todas as funcionalidades de acordo com o esperado.
Um ponto que preciso levantar aqui: na deleção de mensagens, ao clicar duas vezes sobre uma mensagem, é sempre a mensagem mais antiga que é deletada, e não a mensagem na qual o usuário clicou! Isso deve ser alguma questão em torno do parâmetro messageIndex do método removeMessage no arquivo Message.js, ele deve estar vindo com o valor errado, alguns logs nele podem deixar mais claro!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.