Relay properties of progressions as well#127
Open
mlell wants to merge 3 commits intofutureverse:developfrom
Open
Relay properties of progressions as well#127mlell wants to merge 3 commits intofutureverse:developfrom
mlell wants to merge 3 commits intofutureverse:developfrom
Conversation
The steps= argument of progressor did not match the actual number of emitted progressions or rather the sum of their `amount=`s (there are progressions with amount=0) as well in slow_sum()
When the progression condition that is to be relayed was created with any arguments, they need to be relayed as well when creating a new progression object in progress_aggregator(). Fixes futureverse#126.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disassembles a progression condition that is to be relayed and creates a new progression object using all of its properties to adress the problems in #126.
As a perspective, one might think of adding a new class, like "relayedProgression" to progressions that are relayed like this and keep the original progressor ID, session ID and call, though I do not know what it would be useful for.