-
Notifications
You must be signed in to change notification settings - Fork 62
MLEP: Implementation Repository System #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This makes it easier to manipulate images with css.
…oad image from new URL. Note: I cannot remember the exact time I made this commit.
|
I found that I got my fork repo in a huge mess so I extracted patches, reapplied them and made commits cleaner. $ git logcommit a1a7f80 (HEAD -> enhance, origin/master, origin/HEAD) Author: 23Xor Date: Tue Dec 6 16:22:53 2022 +0800commit 515a048 commit c669107 commit 703021a commit dce85e9 commit 0673889 commit 68f1433 commit 39fc9c6 commit 6416429 (origin/change-1div) commit c848970 commit 8b5fc51 (origin/change-refresh, master) |
|
Glad that someone's trying to develop this. Does it work for you though? Your script isn't working for me on any sites |
You need to set a valid repo URL in the settings panel. |
|
what kind of functionality/fixes does this bring that a non-dev user would care about? Though I added several user experience features to my own branch, javascript ain't my forte so I struggled enough trying to figure out what I was doing yet alone trying to be provide peer review. I'll note that I generally preferred having everything in one big .js file instead of being all spread out. Also the only non-nsfw site I found that worked while I was playing around with my changes was https://fanfox.net/ so I would be interested in knowing whether or not you managed to fix compatability with the other sites. |
It will make fixing them easier, one big js will make finding a certain implementation inside the file kind of unbearable pain, About splitting the file, as you said
You should know that in other langs, the ability of modularization or just splitting the file is just a basic. When a project grow larger, they just have to do this so that they will not become an annoying disorder.
For me, testing all those sites is also kind of pain because sometimes it is hard to know whether the site is really down or I am just not using the right proxy(<- illegal thing!). |
See https://github.com/TsXor/manga-loader/blob/enhance/MLEP-IRS.md for details.
I don't think @fuzetsu can see this, but at least I should declare its existance.
This PR contains my previous enhances as well.