Skip to content

Conversation

@TsXor
Copy link

@TsXor TsXor commented Dec 6, 2022

See https://github.com/TsXor/manga-loader/blob/enhance/MLEP-IRS.md for details.
I don't think @fuzetsu can see this, but at least I should declare its existance.

This PR contains my previous enhances as well.

@TsXor
Copy link
Author

TsXor commented Dec 6, 2022

@sprdk4 @SilentSparrow02

@TsXor
Copy link
Author

TsXor commented Dec 6, 2022

I found that I got my fork repo in a huge mess so I extracted patches, reapplied them and made commits cleaner.
Here is original git log if anyone is interested...

$ git log commit a1a7f80 (HEAD -> enhance, origin/master, origin/HEAD) Author: 23Xor Date: Tue Dec 6 16:22:53 2022 +0800
Add Implementation Repository System proposal.

commit 515a048
Author: 23Xor zhang050525@qq.com
Date: Tue Dec 6 11:44:51 2022 +0800

add impl editor

commit c669107
Author: 23Xor zhang050525@qq.com
Date: Mon Dec 5 09:07:31 2022 +0800

adjust matching order

commit 703021a
Author: TsXor 74352334+TsXor@users.noreply.github.com
Date: Mon Dec 5 08:24:44 2022 +0800

fix ero-senmanga

i am lsp ;)

commit dce85e9
Author: 23Xor zhang050525@qq.com
Date: Mon Dec 5 08:13:24 2022 +0800

bugfix

commit 0673889
Author: TsXor 74352334+TsXor@users.noreply.github.com
Date: Sat Dec 3 23:01:41 2022 +0800

Update and rename version.json to version

commit 68f1433
Author: 23Xor zhang050525@qq.com
Date: Sun Dec 4 16:20:01 2022 +0800

now it is usable

commit 39fc9c6
Author: 23Xor zhang050525@qq.com
Date: Sat Dec 3 22:40:20 2022 +0800

*merge features from other branches*
Let Manga Loader load impls dynamically.
NOT READY TO USE

commit 6416429 (origin/change-1div)
Author: TsXor 74352334+TsXor@users.noreply.github.com
Date: Sun Dec 26 18:07:00 2021 +0800

Update manga-loader.user.js

commit c848970
Author: TsXor 74352334+TsXor@users.noreply.github.com
Date: Sat Dec 18 21:43:47 2021 +0800

Update manga-loader.user.js

commit 8b5fc51 (origin/change-refresh, master)
Author: Daniel Loomer fuzetsu@users.noreply.github.com
Date: Wed Aug 5 20:22:57 2020 -0400

get rid of bad domain in namespace field

fixes #68

@SilentSparrow02
Copy link

Glad that someone's trying to develop this. Does it work for you though? Your script isn't working for me on any sites

@TsXor
Copy link
Author

TsXor commented Dec 8, 2022

Glad that someone's trying to develop this. Does it work for you though? Your script isn't working for me on any sites

You need to set a valid repo URL in the settings panel.
For example: https://raw.githubusercontent.com/TsXor/manga-loader/enhance/impls/
I set the default value to https://raw.githubusercontent.com/fuzetsu/manga-loader/master/impls/, which will not work until fuzetsu take any action ;)
Oh I forgot we cannot open setting panel when there is no impl... a dead loop :(
You can search for a line in the script which starts with var default_repo_url = and change the link after it to https://raw.githubusercontent.com/TsXor/manga-loader/enhance/impls/

@sprdk4
Copy link

sprdk4 commented Dec 9, 2022

what kind of functionality/fixes does this bring that a non-dev user would care about? Though I added several user experience features to my own branch, javascript ain't my forte so I struggled enough trying to figure out what I was doing yet alone trying to be provide peer review. I'll note that I generally preferred having everything in one big .js file instead of being all spread out. Also the only non-nsfw site I found that worked while I was playing around with my changes was https://fanfox.net/ so I would be interested in knowing whether or not you managed to fix compatability with the other sites.

@TsXor
Copy link
Author

TsXor commented Dec 9, 2022

what kind of functionality/fixes does this bring that a non-dev user would care about? Though I added several user experience features to my own branch, javascript ain't my forte so I struggled enough trying to figure out what I was doing yet alone trying to be provide peer review. I'll note that I generally preferred having everything in one big .js file instead of being all spread out.

It will make fixing them easier, one big js will make finding a certain implementation inside the file kind of unbearable pain,
Also, when you put all impls in one big js, browser have to load all impls every time, I not only splitted them , but also make them loaded only when needed.
Also, the User Override and impl editor make it easier to test new impls and avoids confusions like #81

About splitting the file, as you said

javascript ain't my forte

You should know that in other langs, the ability of modularization or just splitting the file is just a basic. When a project grow larger, they just have to do this so that they will not become an annoying disorder.

Also the only non-nsfw site I found that worked while I was playing around with my changes was https://fanfox.net/ so I would be interested in knowing whether or not you managed to fix compatability with the other sites.

For me, testing all those sites is also kind of pain because sometimes it is hard to know whether the site is really down or I am just not using the right proxy(<- illegal thing!).
Just like you may not be able to test dmzj in your internet. You may use proxies only for being anonymous and secure your privacy, but it is what I need to access even github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants