Supports media keys: long press volume up , long press volume down, play/pasue.#1
Open
joegege wants to merge 2 commits intofvacek:masterfrom
joegege:master
Open
Supports media keys: long press volume up , long press volume down, play/pasue.#1joegege wants to merge 2 commits intofvacek:masterfrom joegege:master
joegege wants to merge 2 commits intofvacek:masterfrom
joegege:master
Conversation
long press volume Up - next song; long press volume Down - previous song(not work actually, because long press consume 600+ms); play/pause key; x - quit application;
Owner
|
I think, that I can merge your changes to master branch, when review phase will be finished. Please look at my comments on your pull request. |
Owner
|
ad For long press volume down, can only back to the begin of current song, because long press consume 600+ms.: I think that we can change to previous track threshold to let say 650ms |
Contributor
Author
|
I have refined code and submit new pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long press volume Up - next song;
long press volume Down - previous song(not work actually, because long press consume 600+ms);
play/pause key;
x - quit application;
For long press volume down, can only back to the begin of current song, because long press consume 600+ms.