fix: integrate prettier and resolve all linting issues #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add eslint-config-prettier to prevent ESLint/Prettier conflicts - Update lint commands to include Prettier formatting checks - Fix all 61 linting issues (44 errors, 17 warnings) - Prettier already included in CI via updated lint command
…t errors - Add typecheck (tsc --noEmit) to npm run lint command - Fix all TypeScript type errors across test files - Fix all ESLint errors with proper type annotations - Update CI workflow to only run npm run lint (removes separate typecheck) - Ensure both type checking and linting pass together
fx
added a commit
that referenced
this pull request
Jul 8, 2025
* fix: integrate prettier and resolve all linting issues - Add eslint-config-prettier to prevent ESLint/Prettier conflicts - Update lint commands to include Prettier formatting checks - Fix all 61 linting issues (44 errors, 17 warnings) - Prettier already included in CI via updated lint command * fix: consolidate typecheck into lint command and resolve all type/lint errors - Add typecheck (tsc --noEmit) to npm run lint command - Fix all TypeScript type errors across test files - Fix all ESLint errors with proper type annotations - Update CI workflow to only run npm run lint (removes separate typecheck) - Ensure both type checking and linting pass together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Prettier Integration
eslint-config-prettierto prevent ESLint/Prettier conflictslintcommand to run both ESLint and Prettier checkslint:fixcommand to run both ESLint fixes and Prettier formattingLinting Issues Fixed
anytypes with proper TypeScript typesTesting
npm run lint✓npm test✓npm run typecheck✓Related
Follows recommendations from PR #33