feat: massive DSL improvements and validation system #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new trigger types: Power, Runes, Talent, CombatState - Fix parent-child relationship issues in WeakAura export - Remove UID suffixes from IDs to prevent import failures - Add all_descendants method for proper hierarchy traversal - Update CLAUDE.md with testing guidelines - Add devcontainer post-install script
- Add new trigger types: buff_active, debuff_active, cooldown_ready - Implement parent-child relationship tracking for dynamic groups - Add comprehensive RSpec test for WeakAura DSL - Create generic DSL compilation test script - Add WeakAura schema and TypeScript types - Update frost DK example with new trigger types - Fix dynamic group parent tracking - Update CLAUDE.md with testing guidelines
…d spell names - Add simc as git submodule for spell data validation - Create focused DPS rotation WeakAura for Marksmanship Hunter - Validate all spell names against SimulationCraft data - Include core rotation, resource tracking, and talent abilities - Fix main aura title to not be empty (MM Hunter)
- Implement comprehensive Voidweaver rotation tracking - Add DoT management with pandemic timers - Include burst window tracking with Entropic Rift - Track key procs (Surge of Insanity, Deathspeaker, Mind Devourer) - Add M+ utility abilities (Silence, Dispersion, etc.) - 32 total auras organized in 5 logical groups
…as and BAM) - Consolidate 5 groups into required 2-group structure - WhackAuras group: all abilities, procs, DoTs, utilities - BAM group: major offensive cooldowns only - Fix DSL syntax errors (grow direction:) - Remove duplicate DoT tracking entries - Total 27 auras (19 in WhackAuras, 6 in BAM)
- Update WhackAuras creator agent to require exactly 3 groups - BAM group: offensive cooldowns (small, top-left) - Defensive group: defensive abilities (small, top-right) - WhackAuras group: main rotation (larger, center) - Update Shadow Priest Voidweaver to follow new structure - Total 30 auras: 6 BAM, 4 Defensive, 17 WhackAuras
- Remove unnecessary abilities (Fade, Silence, Psychic Scream) - DoTs now show when missing OR expiring (not just expiring) - Mind Flay only shows when Insanity-empowered - Reduced to 27 total auras for cleaner display
- Use icon blocks with multiple triggers for DoT tracking - Trigger 1: Shows when debuff is missing from target - Trigger 2: Shows when debuff is expiring (pandemic window) - Triggers use OR logic (disjunctive: 'any') - Shadow Word: Pain: missing OR < 5.4s remaining - Vampiric Touch: missing OR < 6.3s remaining
- Add debug_log! method to enable WeakAuras debug logging - Sets information.debugLog = true in generated JSON - Propagates to all child auras automatically - Helps troubleshoot aura behavior after successful import
- Fix empty condition check arrays when using glow! with auras option - Improve Feral Druid DoT tracking using icon blocks with multiple triggers - Ensure unique aura IDs to prevent import failures - Use correct spell names in triggers while maintaining readable IDs
- Document common import failure causes and solutions - Add debugging tips for import issues - Include DoT tracking pattern examples - Explain debug_log! usage and limitations
Add WeakAuras2 repository as submodule for spell validation and testing
- Fix map_triggers to use numeric keys (1, 2) instead of string keys ("1", "2")
- Change all untrigger fields from arrays [] to objects {} across trigger types
- Update actions field structure from null to proper {init: [], start: [], finish: []}
- Add generateLuaTable function to encode.lua for debugging
These changes resolve WeakAura import failures where malformed JSON structure
caused imports to hang or fail validation.
- Add parse_simc_data.rb to extract spell/talent data from SimC SpellDataDump files - Add build_spell_mappings.rb to generate Ruby modules from JSON data - Create comprehensive spell (15,752) and talent (2,985) mappings from all WoW classes - Generate both JSON data files and Ruby modules for flexible access - Include search functions and metadata (spec, tree, row, col) for talents This replaces the previous JavaScript-generating-Ruby approach with proper Ruby scripts and clean data separation. Data sourced from ./simc/SpellDataDump/ following the format: "Name : Primal Wrath (id=285381)"
- Update talent trigger to convert string names to numeric IDs using SpellData - Add SpellData module loading in make.rb for DSL compilation - Include graceful error handling and fallback for missing spell data - Example: "Primal Wrath" → 285381 for proper WeakAura validation This resolves the core import issue where talent triggers using string names like "Primal Wrath" were causing WeakAura imports to hang during validation. Now talent_active 'Primal Wrath' automatically becomes talent ID 285381.
- Add npm scripts: parse-simc, build-mappings, update-spell-data, compile-dsl, build-wa - Create build-wa.sh for end-to-end Ruby DSL → WeakAura string conversion - Split encode.ts into encode-wa.ts and generate-lua.ts for better separation - Add complete pipeline: ruby file → JSON → encoded WA string Usage: npm run build-wa public/examples/druid/feral.rb Outputs ready-to-import WeakAura strings with proper talent ID conversion.
- Add scripts/README.md documenting the Ruby parsing and build pipeline - Update CLAUDE.md with new npm scripts and spell data management commands - Add docs/weakaura_structure.md with complete WeakAura LUA structure analysis - Document two-stage process: SimC txt → JSON → Ruby modules - Include usage examples and troubleshooting information Documents the refactored spell data system that replaces JavaScript-generated Ruby code with proper Ruby scripts and clean data separation.
- Update feral druid example with better talent usage and debug logging - Fix WeakAura ID generation to avoid duplicates and improve structure - Update weakaura-dsl-validator agent to use comprehensive structure documentation - Enhance whackauras-creator agent with better Ruby DSL guidance - Improve group and dynamic_group implementations These changes ensure the DSL examples work correctly with the new talent ID conversion system and provide better validation through updated agents.
- Fix ActionUsable triggers to use spell IDs instead of names - Fix Talent triggers to include both trait and spell IDs - Add spec/class info to talent triggers (spec: 2, class: "DRUID") - Auto-use ALL logic when talent triggers present - Standardize untrigger format to [] across all triggers - Fix parent_node passing in talent_active method Resolves Primal Wrath import issues in WeakAuras.
- Add SimC structured data parser for comprehensive spell extraction - Replace unreliable text parsing with structured .inc file parsing - Extract spell descriptions with HP requirements (Execute, Hammer of Wrath) - Implement class-aware spell matching using class masks - Generate concise validation table showing requirements and HP thresholds Key improvements: - Parse spell data, spelltext, talents, and spec spells from SimC .inc files - Extract critical requirements like "<20% HP" from spell descriptions - Use class masks to find appropriate spell variants per class - Show validation results in compact table format instead of verbose output
- Extract requirements from original descriptions before cleaning variables - Use spell ID mapping for variable placeholders like $s2% health - Add specific mappings for Execute (5308), Kill Shot (320976), Hammer of Wrath (24275) - Now correctly shows "<20% HP" for all execute-style abilities across classes Tested with: - Warrior Execute: shows "<20% HP" requirement - Paladin Hammer of Wrath: shows "<20% HP" requirement - Hunter Kill Shot: shows "<20% HP" requirement
…ments - Add new aura_status trigger for checking WeakAura active/inactive states - Improve talent trigger with multi-choice support and better ID resolution - Add comprehensive RSpec tests for both trigger types - Update icon and whack_aura with new trigger support - Add required dependency loading for talent/class mappings
… scripts - Add validate-weakaura-spells.rb for automated spell validation - Add parse_class_spec_data.rb for WoW class/spec mapping generation - Add parse_talent_choices.rb for talent choice relationship parsing - Add parse_detailed_spell_data.rb for SimC spell data processing - Enable automated cross-referencing of DSL spells with SimC data
- Simplify frost death knight example with clean 3-group structure - Update marksmanship hunter to use proper BAM/Defensive/WhackAuras layout - Enhance protection paladin with comprehensive ability tracking - Improve retribution paladin with PvP-focused optimization - Add debug_log! to all examples for import troubleshooting - Apply consistent scaling and positioning across all examples
- Update weakaura-dsl-validator with comprehensive spell validation script usage - Add detailed spell requirement analysis patterns from SimC data - Document automated validation workflow and common failure patterns - Update whackauras-creator with modern 3-group structure template - Add proper scaling, positioning, and trigger usage guidelines
- Add .npmrc for package management configuration - Update package.json with new tooling dependencies - Enhance Lua encode.lua with improved error handling - Add TypeScript decode-wa.ts for WeakAura string decoding
- Add class_spec_data.json with WoW API class/spec mappings - Add class_spec_mappings.rb for Ruby DSL integration - Add talent_choices.json with talent choice relationships - Add talent_choice_mappings.rb for DSL talent resolution - Enable automatic conversion from talent names to numeric IDs
- Add separate validation for defensive/utility spells vs rotation spells - Hunter defensives (Aspect of Turtle, Exhilaration, Survival of Fittest) now validated properly - Defensive spells checked against known class ability lists instead of rotation profiles - Broader DBC validation for class abilities not in rotation - Prevents incorrect removal of essential defensive abilities
- Replace validate-weakaura-spells.rb with compile-dsl.rb --analyze - Update validation workflow to use SimC profile-based validation - Add detailed spell requirements parsing from DBC data - Update examples to show current spell validation format - Focus on ✗ NOT FOUND vs ✓ VALID status indicators
- Remove validate-weakaura-spells.rb in favor of integrated --analyze command - Consolidate validation logic into compile-dsl.rb for better maintainability
- Remove Multi-Shot (not in MM rotation profile) - Promote Explosive Shot to main rotation with glow effect - Restore defensive abilities (Aspect of Turtle, Exhilaration, Survival of Fittest) - Align with actual SimC Marksmanship Hunter rotation priorities
- Add comprehensive spell coverage for testing validation - Include both valid spells (Pillar of Frost, Obliterate) and invalid spells (Abomination Limb) - Demonstrate proper WeakAura structure with BAM, Defensive, and WhackAuras groups - Provide test case for covenant ability removal validation
- Document new compile-dsl.rb --analyze command for testing - Update spell data sources to use SimC DBC data - Add information about spell validation using rotation profiles - Document enhanced requirement parsing capabilities
- Add better handling for dynamic group properties - Improve node creation and management - Support enhanced validation workflow
Replace hardcoded Kill Shot logic with systematic algorithm that: - Prefers lower spell IDs (typically base abilities) - Handles high-ID variants (>300k) by choosing lower alternatives - Ensures action_usable triggers use correct player spell IDs - Kill Shot now correctly resolves to 53351 instead of 320976
- Compiles all .rb files in public/examples/ with --analyze - Catches spell ID mapping and compilation issues - Runs on pushes and PRs to prevent regressions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
===========================================
+ Coverage 56.78% 70.76% +13.98%
===========================================
Files 35 51 +16
Lines 678 1423 +745
Branches 29 37 +8
===========================================
+ Hits 385 1007 +622
- Misses 281 403 +122
- Partials 12 13 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces massive DSL improvements and a comprehensive validation system for the WeakAuras Ruby DSL. The changes enhance spell ID resolution to use base spell IDs rather than variant IDs, add CI validation for all DSL examples, and implement a robust spell validation system using SimC data.
Key changes include:
- Implementation of comprehensive spell data parsing from SimulationCraft sources
- Enhanced trigger system with talent validation and complex trigger conditions
- Addition of CI validation pipeline for all DSL examples
Reviewed Changes
Copilot reviewed 65 out of 71 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/talent_trigger_spec.rb | Adds comprehensive tests for talent trigger generation with correct spell IDs |
| scripts/parse_*.rb | Multiple SimC data parsing scripts for extracting spell, talent, and class data |
| scripts/compile-dsl.rb | Complete DSL compilation pipeline with spell validation system |
| public/whack_aura.rb | Enhanced DSL with new trigger methods (power_check, talent_active, etc.) |
| public/weak_aura/triggers/*.rb | New trigger classes for talents, power, runes, combat state, and aura status |
| public/weak_aura/*.rb | Updated WeakAura components with improved trigger handling and parent-child relationships |
| public/examples/*.rb | Enhanced example DSL files with complex rotation logic and talent conditions |
- Fix 4 failing DSL examples by correcting method usage - Fix infinite recursion in Node#information_hash - Fix glow! condition structure for proper test compatibility - Simplify DSL examples to use supported syntax patterns These changes resolve the validate-examples and rspec test failures without breaking existing functionality.
- Make Node#as_json public (casting gem makes it private) - Update spell name tests to expect spell IDs (184367 for Rampage, 12294 for Mortal Strike) - Fix stacks value type in Auras trigger (integer instead of string) - Enable use_talent flag in Talent trigger - Update AuraStatus trigger tests to match actual implementation (GetRegion vs IsDisplayActive)
- Add comprehensive tests for spell-data.ts (37 lines) - Add tests for decode-wa.ts and generate-lua.ts Lua scripts - Add tests for missing Node.rb methods and edge cases - Improves patch coverage for codecov validation
- Fix RSpec have matcher usage (replaced with .length.to eq) - Add debug_log_enabled getter method to WeakAura class - Simplify Lua E2E tests to avoid complex mock.calls issues - All test suites now passing
- Add missing requires for casting, digest, and json to node.rb - Fix talent_trigger_spec.rb to use spec_helper and correct types - Fix symbol vs string key access in test assertions - All RSpec tests now passing
- Extract Primal Wrath hardcoded logic to configurable EXTRA_TRAIT_IDS_FOR_TALENTS - Fix duplicate charge_cooldown field in comment - Improve data structure comment consistency in parse script - Extract POWER_TYPES constant to shared WeakAuraConstants module - Add get_triggers_data helper method to reduce glow! complexity - Implement spell data caching to avoid repeated file I/O operations - All 6 Copilot review comments addressed
…ments - Fixed duplicate charge_cooldown field in parse_simc_structured_data.rb comment - Updated misleading comment in compile-dsl.rb to accurately reflect parsed fields
- Document acceptable patterns to prevent recurring false positives - Include notes about EXTRA_TRAIT_IDS, POWER_TYPES, glow! complexity, and script caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan