Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 10, 2025

  • Upgrade Next.js from 14.2.31 to 14.2.33 to fix SSRF vulnerability (GHSA-4342-x723-ch2f / CVE-2025-57822)
  • Upgrade eslint-config-next to 14.2.33 to match Next.js version
  • Run npm audit fix to address other vulnerabilities (js-yaml, playwright, vite)
  • Verify build works with upgraded dependencies
  • Run tests to confirm no regressions
  • Run code review and security checks
  • Add Node.js version requirements (>=20.0.0) via engines field and .nvmrc for Vercel deployment
Original prompt

upgrade next.js because of its currently vulnerability


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 10, 2025
Copilot AI assigned fx Dec 10, 2025
@vercel
Copy link

vercel bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
weakauras Ready Ready Preview Comment Dec 10, 2025 5:46pm

Copilot AI changed the title [WIP] Update Next.js to address security vulnerability Upgrade Next.js to 14.2.33 to fix SSRF vulnerability (CVE-2025-57822) Dec 10, 2025
Copilot AI requested a review from fx December 10, 2025 17:19
@fx
Copy link
Owner

fx commented Dec 10, 2025

@copilot The build has failed now

Error: Node.js Version "18.x" is discontinued and must be upgraded. Please set Node.js Version to 24.x in your Project Settings to use Node.js 24. Learn More: http://vercel.link/node-version

Copilot AI and others added 2 commits December 10, 2025 17:44
Co-authored-by: fx <27249+fx@users.noreply.github.com>
Co-authored-by: fx <27249+fx@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 10, 2025

@copilot The build has failed now

Error: Node.js Version "18.x" is discontinued and must be upgraded. Please set Node.js Version to 24.x in your Project Settings to use Node.js 24. Learn More: http:/...

Fixed in 37e0d38. Added Node.js version requirements:

  • Added engines field to package.json specifying node: ">=20.0.0"
  • Added .nvmrc file with version 20 for Vercel deployment

This should resolve the Vercel build failure by specifying Node.js 20 as the required version.

Copy link
Owner

@fx fx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👀👌👀👌👀👌👀👌👀 good shit go౦ԁ sHit👌 thats ✔ some good👌👌shit right👌👌there👌👌👌 right✔there ✔✔if i do ƽaү so my self 💯 i say so 💯 thats what im talking about right there right there (chorus: ʳᶦᵍʰᵗ ᵗʰᵉʳᵉ) mMMMMᎷМ💯 👌👌 👌НO0ОଠOOOOOОଠଠOoooᵒᵒᵒᵒᵒᵒᵒᵒᵒ👌 👌👌 👌 💯 👌 👀 👀 👀 👌👌Good shit

@fx fx marked this pull request as ready for review December 10, 2025 18:32
Copilot AI review requested due to automatic review settings December 10, 2025 18:32
@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.78%. Comparing base (73c8565) to head (37e0d38).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   56.78%   56.78%           
=======================================
  Files          35       35           
  Lines         678      678           
  Branches       29       29           
=======================================
  Hits          385      385           
  Misses        281      281           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades Next.js from version 14.2.31 to 14.2.33 to address a critical SSRF (Server-Side Request Forgery) vulnerability (CVE-2025-57822 / GHSA-4342-x723-ch2f). The upgrade ensures the application is protected against this security vulnerability while maintaining compatibility with the existing codebase.

Key changes:

  • Next.js upgraded to 14.2.33 to fix SSRF vulnerability
  • Related packages updated for version consistency (eslint-config-next, transitive dependencies)
  • Node.js version requirement formalized with engines field and .nvmrc file

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updated Next.js to 14.2.33, eslint-config-next to 14.2.33, and added engines field requiring Node.js >=20.0.0
package-lock.json Updated lock file with new versions of Next.js, its platform-specific binaries, eslint-config-next, and transitive dependencies (glob, js-yaml, playwright, vite)
.nvmrc Added Node.js version specification (20) for consistent development environment and Vercel deployment
public/index.json Reordered Rogue: Outlaw entry (likely from running prebuild script, no functional change)

@fx fx merged commit ca4b68b into main Dec 10, 2025
14 checks passed
@fx fx deleted the copilot/upgrade-next-js-version branch December 10, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants