Clarify a security consideration and link to Section 1.2 of RFC 8949 #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old text: CCF decoders MUST detect and reject malformed data before checking for validity. [Appendix F](https://www.rfc-editor.org/rfc/rfc8949.html#name-well-formedness-errors-and-) of RFC 8949 defines well-formedness of encoded CBOR data. New text: CCF decoders MUST detect and reject malformed data items before checking for validity. [Section 1.2](https://www.rfc-editor.org/rfc/rfc8949.html#section-1.2) of RFC 8949 defines "well-formed" data items.
fxamacker
added a commit
to onflow/ccf
that referenced
this pull request
Mar 31, 2025
Changes were done at github.com/fxamacker/ccf_draft to reduce noise here during the weekend. For details (individual commits), see: - fxamacker/ccf_draft#103 - fxamacker/ccf_draft#104 NOTE: There were no changes to CDDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old text:
CCF decoders MUST detect and reject malformed data before checking for validity. Appendix F of RFC 8949 defines well-formedness of encoded CBOR data.
New text:
CCF decoders MUST detect and reject malformed data items before checking for validity. Section 1.2 of RFC 8949 defines "well-formed" data items.